Fix window exiting with no message to user if _create_window fails #98405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gromph
force-pushed
the
fix-create-window-failed-message-box
branch
from
3a776f7 to
403e53e
Compare
AThousandShips
added
bug
platform:windows
cherrypick:4.3
bruvzg
approved these changes
Oct 22, 2024
clayjohn
approved these changes
Oct 22, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running godot 4.3 on an old Windows desktop with an ATI Radeon 3000 GPU and forcing it to run with lib angle, it would briefly show a black window and then exit with no error message to the user. With this pull request the user will at least get an error message if _create_window fails