Fix Control offset_* property types

[timoschwarzer]

The documentation and the setter/getter methods state that the offset_* properties of Control nodes are supposed to be float, the property declarations use Variant::INT as property type though. This PR fixes that.

[Chaosus]

If you change a core API, you've also needed to add a change to https://github.com/godotengine/godot/blob/master/misc/extension_api_validation/4.3-stable.expected.

[timoschwarzer]

@Chaosus Thanks for the hint, updated!

[groud]

The documentation is wrong, those are supposed to be INTs. This is because this value is in pixel and sprites/controls that are not aligned to the grid would could look blurry.

Changing this to float requires a proposal, but the documentation should be fixed for now.

[timoschwarzer]

@groud hmm, why is the internal type and the arguments to set_offset and get_offset real_t then and why does the project setting to snap controls to whole pixels exist in project settings then? 🤔 In any way, it's not just the documentation that is wrong here.

[groud]

Ah my bad, you are right. I had wrong memory about this. I am still a bit worried about exposing them as float though, I feel it might be a bit more annoying to deal with in the editor. But well, I don't mind the change, we'll see if people complain.

[timoschwarzer]

@groud I could change the property hint to use 1px stepping. Then it shouldn't be annoying in the editor but you can set it to subpixel values in code.

I just noticed this issue after some time of going crazy while trying to set an offset to some float value in a script and the engine always converting it to a whole number, while insisting on it being a float. Turned out the docs were not telling the truth here 😄

My usecase here is that I render a pixel game in a viewport with supersampling, so an offset of 0.25 game pixels likely end up being multiple screen pixels.

[groud]

@groud I could change the property hint to use 1px stepping. Then it shouldn't be annoying in the editor but you can set it to subpixel values in code.

Sounds good to me!

[timoschwarzer]

@groud Changed the hint to use 1px stepping as well as allowing to enter values less than -4096 and greater than 4096 since these limits seemed arbitrary/obsolete to me.

[Repiteo]

Thanks!