Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "OpenGL 3", "GLES" and "Linux/*BSD" to editor property capitalization #98553

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 26, 2024

This is required to capitalize the following settings:

  • Fallback to OpenGL 3 project setting
  • Fallback to GLES project setting
  • Linux/*BSD category in the Editor Settings

Preview

Note that "ANGLE" can't be capitalized here, because it's often used to refer as an angle, not as the graphics API translation library.

Screenshot_20241026_151740

Screenshot_20241026_151746

image

@Calinou Calinou added this to the 4.4 milestone Oct 26, 2024
@Calinou Calinou requested a review from a team as a code owner October 26, 2024 13:42
@SheepYhangCN
Copy link
Contributor

SheepYhangCN commented Oct 26, 2024

About the project settings capitalization problem
I wonder why can't we just add a "display_name" for project settings
instead of use the "name" and auto capitalize it

@timothyqiu
Copy link
Member

timothyqiu commented Oct 26, 2024

@SheepYhangCN We can. But in practice, almost 93% of the properties will be simply hardcoded with the same result as capitalize(). Not to mention the same property names scattered across different files, and keeping them consistently capitalized is a lot of work too

The project settings dialog is essentially an Inspector showing ProjectSettings members.

@Calinou Calinou force-pushed the editor-capitalization-opengl branch from 7973167 to 7e81bb9 Compare October 26, 2024 14:23
@Calinou Calinou changed the title Add "OpenGL 3" and "GLES" to editor property capitalization Add "OpenGL 3", "GLES" and "Linux/*BSD" to editor property capitalization Oct 26, 2024
…tion

This is required to capitalize the following settings:

- "Fallback to OpenGL 3" project setting
- "Fallback to GLES" project setting
- "Linux/*BSD" category in the Editor Settings
@Calinou Calinou force-pushed the editor-capitalization-opengl branch from 7e81bb9 to d352bbc Compare October 26, 2024 14:24
@clayjohn clayjohn merged commit 5bf52d1 into godotengine:master Oct 28, 2024
20 checks passed
@clayjohn
Copy link
Member

Thank you!

@Calinou Calinou deleted the editor-capitalization-opengl branch October 28, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants