Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Occlusion Culling not working for an orthogonal camera. #98562

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Rudolph-B
Copy link
Contributor

Fixes #98561

This issue was caused by two problems:

This PR fixes both.

MRP: mrp.zip

@Rudolph-B Rudolph-B requested a review from a team as a code owner October 26, 2024 18:16
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 27, 2024
@AThousandShips AThousandShips added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 27, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@clayjohn clayjohn added regression and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 27, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected, but only at high zoom levels.

Culling doesn't work anymore once you unzoom the orthogonal camera in the editor:

simplescreenrecorder-2024-10-28_16.58.18.mp4

Moving the cube further away from the wall doesn't resolve this.

@Rudolph-B
Copy link
Contributor Author

I see. It seems the occlusion buffer disorientates itself somehow when zoomed out.
Screencast from 2024-10-28 18-59-25.webm.
Not really sure how this happens yet. I'll fix it.

@Repiteo Repiteo merged commit 64b6819 into godotengine:master Oct 30, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occlusion Culling does not work with an orthogonal camera
5 participants