Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement native input dialog support #98574

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

syntaxerror247
Copy link
Member

This PR brings native input dialog support to Android, aligning with existing functionality currently available only on macOS and Windows.

It provides Android's native text selection handles, this can be useful for single-text-box scenarios where user input is required.

Demo video

Screenrecorder-2024-10-27-17-05-13-255.mp4

Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Added some minor comments to address.

@m4gr3d m4gr3d modified the milestones: 4.x, 4.4 Oct 28, 2024
@Repiteo Repiteo merged commit 08d8909 into godotengine:master Oct 30, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 30, 2024

Thanks!

@syntaxerror247 syntaxerror247 deleted the android_input_dialog branch October 30, 2024 03:29
@llama-nl
Copy link

llama-nl commented Oct 30, 2024

@syntaxerror247 how does it work? Does it work with code editor? Can I have the apk with more examples?

Also the ui is like old Android version. Can you make the ui better?

@syntaxerror247
Copy link
Member Author

syntaxerror247 commented Nov 3, 2024

@UnderGamer05 You can use this with DisplayServer.dialog_input_text.

Currently, It is not integrated in editor.

For better UI see this proposal godotengine/godot-proposals#11071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants