Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fallbacks to OpenGL #98615

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix fallbacks to OpenGL #98615

merged 1 commit into from
Oct 30, 2024

Conversation

Summersay415
Copy link
Contributor

Take in account definition of GLES3_ENABLED
Fix fallback logic on Android

@Summersay415 Summersay415 marked this pull request as ready for review October 28, 2024 14:06
@Summersay415 Summersay415 requested review from a team as code owners October 28, 2024 14:06
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 28, 2024
m4gr3d
m4gr3d approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Android section looks good!

AThousandShips
AThousandShips reviewed Oct 28, 2024
View reviewed changes
@Repiteo Repiteo merged commit 05a4620 into godotengine:master Oct 30, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 30, 2024

Thanks!

@Summersay415 Summersay415 deleted the three-opengls-please branch October 30, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@m4gr3d m4gr3d m4gr3d approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Summersay415 @Repiteo @m4gr3d @bruvzg @AThousandShips