Generate build status-dependent icons for the editor

[tehKaiN]

Closes godotengine/godot-proposals#541

Also auto-generates the icons for console executables under Windows. They are not pixel-exact to the previous ones, since they're composited dynamically, but they should be close enough.

Sample preview using some kind of web-based .ico previewer - might be a bit distorted.

Caveats:

• Icon components are rendered to PNG first, then composited, because doing everything in SVG and then converting to PNG yielded bad results - some lines were thinner than others, also getting color-mixed with the neighbors.
• I'm mainly a programmer, so SVGs present in the PR are not perfect - though I assume they are good enough placeholders. I've concocted them in GodSVG in conjunction with some kind of web-based SVG text path generator.
• No linux icons because I couldn't get any response on how to tackle it in the proposal issue. :(

Also it made a bit of make_icons.sh obsolete, so perhaps it could supersede it further? I don't know how it's called though - make_icons.py is intended to generate files which are to be commited, whereas it looks like make_icons.sh is used for packaging?

[bruvzg]

No linux icons because I couldn't get any response on how to tackle it in the proposal issue. :(

The script for generating PNGs is pretty much all that can be done, Linux icon is not part of the executable or official distribution, so it's up to distro specific package maintainers how to use it.

like make_icons.sh is used for packaging?

Not sure if it's used for anything (definitely not used in the official build pipeline).

[bruvzg]

There's also embedded PNG icon which is used for window title / taskbar / task switcher:

godot/main/SCsub

Lines 35 to 40 in a308047

	env_main.Depends("#main/app_icon.gen.h", "#main/app_icon.png")
	env_main.CommandNoCache(
	"#main/app_icon.gen.h",
	"#main/app_icon.png",
	env.Run(main_builders.make_app_icon),
	)

[tehKaiN]

The script for generating PNGs is pretty much all that can be done, Linux icon is not part of the executable or official distribution, so it's up to distro specific package maintainers how to use it.

That should be easily doable, but I need to know what kind of PNG sizes are needed.

[bruvzg]

That should be easily doable, but I need to know what kind of PNG sizes are needed.

No sure if there's a standard set of sizes. The following seems to be used 16x16, 22x22, 24x24, 32x32, 48x48, 64x64, 96x96, 128x128, 192x192, 256x256, but not every icon is using all of them. Some apps also use single SVG instead.

[tehKaiN]

I've added a bunch of linuxbsd icons. Also generates the SVG variant. The problem is, generated icons don't pass through svgo, but since the pre-commit hook generates the optimized variant, and the script doesn't need to run that often, perhaps that's acceptable? If not then there's a problem - I see no better SVG libary than cairo and I'm not quite sure if text-based svg editing won't trigger the svgo anyway.

[tehKaiN]

What's the status of this PR? I know it's probably of very low priority, but perhaps there are some concerns that I could investigate in the meantime.

[bruvzg]

macOS and Windows icons look good to me.

[m4gr3d]

The Android section looks good.

[syntaxerror247]

@tehKaiN Can you provide Android icon_monochrome for different sizes too?
This is the svg file, you can resize it: https://godotengine.org/assets/press/icon_monochrome_dark.svg

[tehKaiN]

I didn't know that they are required/nice to have since the original icon set didn't had those. Fixed!
Regarding using SVG, if the quality of current icons isn't good enough then I'll investigate going the SVG route, but that needs extra work to make the dev/beta/rc label svgs monochrome too.

[syntaxerror247]

Regarding using SVG, if the quality of current icons isn't good enough then I'll investigate going the SVG route, but that needs extra work to make the dev/beta/rc label svgs monochrome too.

I had suggested using the SVG as a base image, resizing it to your desired dimensions, and then exporting it as a PNG file. Then you can put dev/beta/RC label on png file.
Anyway, current changes looks good.

[tehKaiN]

A friendly reminder that another month passed by. I know it's super low priority issue, but I wonder - is there some kind of review queue where I could check how things progress? Or should I just wait for the reviews, or perhaps keep pinging here and there from time to time?

[tehKaiN]

Updated the PR for post-4.4 changes.
One thing I see is that 4.4 added android icon_monochrome.png for all the DPI variants. I've removed them since they are already generated in my PR.

One thing that's curious for me is that 4.4 changed the icon_foreground and icon_monochrome proportions in mdpi: previously, and in my PR, it was 66px square icon in 108px transparent square background as per Android guidelines, but now the icon is something around 48px square. It would be nice to have a second opinion on how it should really be.

[syntaxerror247]

One thing that's curious for me is that 4.4 changed the icon_foreground and icon_monochrome proportions in mdpi:

@tehKaiN icon_foreground haven't been updated for last 6 years.

[tehKaiN]

Sorry, it was late yesterday. Anyway, there is discrepancy between proportions of those icons between current version and my version, and I'm not sure whether I should strictly follow what's in the repo currently, or keep it as I've changed it since android docs seem to confirm that latter is better. I'm not an android developer though, so I might got that wrong.