Fix duplicated Delete shortcut entries in Tiles Editor #98629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groud
approved these changes
Oct 29, 2024
akien-mga
approved these changes
Nov 11, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is intended or a leftover from the tiles editor refactoring, but the TileSetAtlasSourceEditor uses different shortcuts for deleting the selected base tile and deleting the selected alternative tile. Their default key bindings are the same, only named differently (but display names are both Delete).
This results in two identical Delete shortcuts in the editor's shortcut list:
This PR merges
tiles_editor/delete_tileintotiles_editor/delete.