Fix certain editor plugins not showing when they should #98675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clicking AnimationTree will always open Animation tab. RmVxy9ktkT.mp4 |
|
@KoBeWi This behavior is due to a different issue (discussed in godotengine/godot-proposals#11009), and is reproducible without this PR. |
|
Not entirely. godot.windows.editor.dev.x86_64_ieaEL62Jka.mp4 |
YeldhamDev
force-pushed
the
dont_be_shy_plugin
branch
from
312883c to
04fb1b8
Compare
|
Alright, I made so that the |
KoBeWi
approved these changes
Dec 8, 2024
YeldhamDev
force-pushed
the
dont_be_shy_plugin
branch
from
04fb1b8 to
b397add
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And by "certain editor plugins", I mean the Animation editor.
The issue happens when an editor plugin is activated, hidden, but then requested again by something else. When a plugin was already activated,
make_visible()wasn't called on it.Fixes #93814.
Sponsored By: 🐺 Lone Wolf Technology / 🍀 W4 Games.