Fix total_visible_line_count calculation when removing and clearing TextEdit's text.
#98678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only partial since I didn't fix the issue with the clear. |
bruvzg
reviewed
Nov 6, 2024
Daylily-Zeleen
force-pushed
the
daylily-zeleen/fix_text_edit
branch
from
8da6d12 to
11db16f
Compare
bruvzg
approved these changes
Nov 6, 2024
… text of `TextEdit`.
Daylily-Zeleen
force-pushed
the
daylily-zeleen/fix_text_edit
branch
from
11db16f to
d22419b
Compare
|
Thanks! |
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fix a bug that when a TextEdit has some folded lines and set its text, the scroll bar can not be updated correctly.
Bugsquad edit: