Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set flag for 8 bone weights in GLTFDocument #98703

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

pgrit
Copy link
Contributor

@pgrit pgrit commented Oct 31, 2024

The glTF importer loads up to 8 bone weights, but does not set the according flag. This results in broken LODs.
Fixes #98650 and possibly also #78636

@pgrit pgrit requested a review from a team as a code owner October 31, 2024 16:13
@fire fire changed the title set flag for 8 bone weights Set flag for 8 bone weights in GLTFDocument Oct 31, 2024
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@AThousandShips AThousandShips added bug topic:import cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 1, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Nov 1, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@Repiteo Repiteo merged commit cd6dad4 into godotengine:master Nov 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2024

Thanks! Congratulations on your first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:import
Projects
Development

Successfully merging this pull request may close these issues.

Corrupted mesh data after import of a specific .blend file
5 participants