Reload cached resources in runtime on file reimport #98710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeldhamDev
force-pushed
the
runtime_reimport_reload
branch
from
062048b to
8f88aad
Compare
clayjohn
approved these changes
Nov 1, 2024
Faless
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Looks good overall, see my comment about the EditorFileSystem check.
I wonder if we should put the reload_cached_files behind the live_debug flag (i.e. synchronize scene changes), and thus also rename the message to live_reload_cached_files and move handling to the live editor.
YeldhamDev
force-pushed
the
runtime_reimport_reload
branch
from
8f88aad to
81cb765
Compare
I thought about that, but decided against it because that's not really a "scene change", and more of an asset data modification. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93629.
Sponsored By: 🐺 Lone Wolf Technology / 🍀 W4 Games.