Don't tint editor bottom panel icons when hovered or pressed #98765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the error/warning icons from turning gray or green, making them hard to recognize. A similar mechanism is already used for EditorLog filter button icons. This also fixes typos in FileDialog theme color assignment (`icon_color_pressed` instead of `icon_pressed_color`). The exposed theme item names remain the same.
ryevdokimov
approved these changes
Nov 2, 2024
MewPurPur
reviewed
Nov 2, 2024
Comment on lines
+1906
to
+1907
| Color icon_hover_color = p_config.icon_normal_color * (p_config.dark_theme ? 1.15 : 1.0); | ||
| icon_hover_color.a = 1.0; |
There was a problem hiding this comment.
Is this meant to be the same thing as the lightened() function?
There was a problem hiding this comment.
Yes, more or less. It's slightly different but probably doesn't matter here.
That said, this may be better to harmonize in a different PR since we use color multiplication all over the place in EditorThemeManager right now.
passivestar
approved these changes
Nov 16, 2024
akien-mga
approved these changes
Nov 29, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the error/warning icons from turning gray or green, making them hard to recognize. A similar mechanism is already used for EditorLog filter button icons.
This also fixes typos in FileDialog theme color assignment (
icon_color_pressedinstead oficon_pressed_color). The exposed theme item names remain the same.icon_hover_pressed_coloris now set for EditorLogFilterButton as well, so you get a subtle visual feedback when hovering the buttons when they're already pressed.This was mentioned in a proposal issue or discussion recently, but I can't find it right now.
Preview
Before
editor_bottom_panel_icon_hover_before.mp4
After
editor_bottom_panel_icon_hover_after.mp4