Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smol-v: update to 2024 to support SPIR-V 1.6 #98771

Merged
merged 1 commit into from
Nov 5, 2024
Merged

smol-v: update to 2024 to support SPIR-V 1.6 #98771

merged 1 commit into from
Nov 5, 2024

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Nov 2, 2024 •
edited by Calinou
Loading

Update smol-v to 2024 version to support SPIR-V 1.6

@stuartcarnie stuartcarnie requested a review from a team as a code owner November 2, 2024 20:09
@stuartcarnie stuartcarnie force-pushed the update_smolv branch 2 times, most recently from f40c979 to 82c71fc Compare November 2, 2024 20:13
@Calinou Calinou added this to the 4.4 milestone Nov 2, 2024
@fire fire requested a review from a team November 4, 2024 19:38
fire
fire approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be an upstream update. If it breaks, we should probably do a dev build to check.

akien-mga
akien-mga approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial update.

@Repiteo Repiteo merged commit 0a2a259 into godotengine:master Nov 5, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 5, 2024

Thanks!

@stuartcarnie stuartcarnie deleted the update_smolv branch November 6, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:thirdparty
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@stuartcarnie @Repiteo @fire @akien-mga @Calinou