Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete stale check, make SCons support globbing with # inside path #98774

Merged

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Nov 2, 2024

Some parts 123 of the buildsystem already were using it with # in path.

I currently work on making buildsystem prettier and more flexible so now I extracted small part of planned work which certainly shouldn't cause any problems

Additionally deleted some unnecessary leading slashes which created several paths with //. It didn't cause any problems but they were unnecessary

Footnotes

  1. https://github.com/godotengine/godot/blob/c6c464cf9ae56e8b68620af65125dd980d0e8122/editor/icons/SCsub#L22

  2. https://github.com/godotengine/godot/blob/c6c464cf9ae56e8b68620af65125dd980d0e8122/editor/SCsub#L71

  3. currently not merged PR by Repiteo ;) https://github.com/godotengine/godot/pull/98653/files#diff-5d2591fb5837decc3fec5e4992821a185ad895888924e4e736a31c7756c067f8R113

Some parts of the buildsystem already were using it with `#` in path

Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
@dustdfg dustdfg requested a review from a team as a code owner November 2, 2024 20:52
@dustdfg
Copy link
Contributor Author

dustdfg commented Nov 2, 2024

Oh and one more thing it seemed to me that check for (str, bytes) is redundant so I changed it to str. If it isn't so let me know

Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must've been around for a while, seeing as even the legacy versions are passing without issue. And yeah, we aren't passing in byte paths anywhere in the repo, so shortening it to just str checks out

@AThousandShips AThousandShips changed the title Deleted stale check. Now SCons supports globbing with # inside path Delete stale check, make SCons support globbing with # inside path Nov 3, 2024
@Repiteo Repiteo merged commit 8536506 into godotengine:master Nov 5, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 5, 2024

Thanks!

@dustdfg dustdfg deleted the scons_use_glob_remove_stale_check branch November 6, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants