Fix issue where scrolling to item center would overflow on top #98829
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
added
bug
topic:editor
usability
cherrypick:4.3
Geometror
approved these changes
Nov 5, 2024
adamscott
force-pushed
the
fix-tree-scroll-center-overflow
branch
from
605515b to
49f918e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a tree scroll could overflow if the scrolling is centered to the item and that the calculation to take into account the items' final height is negative. As the
y_offsetsubtracts the final height of the item, it results in a positive scroll position, when it should be really0.Fix #93899
Supersedes #93918