Allow setting custom initialization vector for FileAccessEncrypted. Add export setting to set static seed for PCK encryption initialization vectors. #98918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
force-pushed
the
pck_enc_iv
branch
2 times, most recently
from
8289472 to
7a31bb3
Compare
akien-mga
reviewed
Nov 12, 2024
akien-mga
approved these changes
Nov 12, 2024
AThousandShips
approved these changes
Nov 12, 2024
bruvzg
force-pushed
the
pck_enc_iv
branch
2 times, most recently
from
4306c06 to
839351d
Compare
|
Needs to be rebased before this can be merged |
Bromeon
reviewed
Nov 12, 2024
core/io/file_access_encrypted.cpp
Outdated
Comment on lines
52
to
58
| if (p_iv.is_empty()) { | ||
| iv.resize(16); | ||
| for (int i = 0; i < 16; i++) { | ||
| iv.write[i] = Math::rand() % 256; | ||
| } | ||
| } else { |
There was a problem hiding this comment.
I don't know the full context here, but does the init-vector not need to be securely random? As repeated invocations of Math::rand() probably have rather low entropy...
There was a problem hiding this comment.
I do not think it matters in this case, but changed it to CryptoCore::RandomGenerator just in case.
…dd export setting to set static seed for PCK encryption initialization vectors.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileAccessEncrypted.seed + file hashare used to generate IV, if zero IV is fully random (old behavior).Fixes #98904