Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused files of thirdparty libs (zlib, mbedtls) #98920

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Nov 7, 2024

They weren't listed inside appropriate source lists (inside SCsub files) so this change shouldn't affect compiled binaries at all but obviously check it

@dustdfg dustdfg requested a review from a team as a code owner November 7, 2024 11:08
@akien-mga akien-mga changed the title Delete unused files of thirparty libs (zlib, mbedtls) Delete unused files of thirdparty libs (zlib, mbedtls) Nov 7, 2024
@akien-mga akien-mga added this to the 4.x milestone Nov 7, 2024
@akien-mga akien-mga requested review from Faless and akien-mga November 7, 2024 11:55
@fire
Copy link
Member

fire commented Nov 7, 2024

Please update the readme with the deletion indtructions

@dustdfg dustdfg force-pushed the thirdparty_delete_unused branch from b7424fc to 16e2374 Compare November 7, 2024 16:44
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Nov 7, 2024
Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
@dustdfg dustdfg force-pushed the thirdparty_delete_unused branch from 16e2374 to b607997 Compare November 7, 2024 16:55
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub actions integration test still functions, the files are deleted, and the readme instructions are updated. It looks good to me.

@Repiteo Repiteo merged commit c02c445 into godotengine:master Nov 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2024

Thanks!

@dustdfg dustdfg deleted the thirdparty_delete_unused branch November 10, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants