Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Fix issue where focus timer would throw continuously #98931

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

adamscott
Copy link
Member

Two commits.

  1. The first makes Web IME code return early instead of being inside an all-encompassing if statement.
  2. The second fixes [Web] Editor throws continuously when calling internally GodotIME.ime.focus() #98928

@adamscott adamscott added this to the 4.4 milestone Nov 7, 2024
@adamscott adamscott requested a review from a team as a code owner November 7, 2024 18:31
@bruvzg bruvzg self-requested a review November 8, 2024 14:06
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine (tested IME on macOS and Windows with Firefox and Chromium).

@Repiteo Repiteo merged commit 0445bfb into godotengine:master Nov 12, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web] Editor throws continuously when calling internally GodotIME.ime.focus()
4 participants