Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] [JavaScript] Don't cache emsdk #99037

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

AThousandShips
Copy link
Member

3.x version of:

See there for more details

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AThousandShips A Thousand Ships
Due to how caches are accessed this cache is almost useless, it only
matters if it is from the same branch or a base branch, and is identical
between branches, so caching it just clutters the build cache
@AThousandShips AThousandShips added bug enhancement platform:web cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release labels Nov 10, 2024
@AThousandShips AThousandShips added this to the 3.7 milestone Nov 10, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner November 10, 2024 19:49
@lawnjelly lawnjelly merged commit 5cef67e into godotengine:3.x Nov 20, 2024
14 checks passed
@lawnjelly
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the emsdk_cache_fix_3_x branch November 20, 2024 11:51
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release enhancement platform:web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants