Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Transform3D.rotated_local() description #99075

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Update Transform3D.rotated_local() description #99075

merged 1 commit into from
Nov 12, 2024

Conversation

PhairZ
Copy link
Contributor

@PhairZ PhairZ commented Nov 11, 2024

fixes #97799

@PhairZ PhairZ marked this pull request as ready for review November 11, 2024 15:05
@PhairZ PhairZ requested a review from a team as a code owner November 11, 2024 15:05
@PhairZ
Copy link
Contributor Author

PhairZ commented Nov 11, 2024

Sorry for the last pr, @Mickeon . Hope this one's better

@AThousandShips AThousandShips added this to the 4.4 milestone Nov 11, 2024
Mickeon
Mickeon approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no need to close the PR outright, but that's okay.

@Repiteo Repiteo merged commit 9300797 into godotengine:master Nov 12, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks! Congratulations on your first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Transform3D.rotate_local does not rotate as expected
4 participants
@PhairZ @Repiteo @Mickeon @AThousandShips