[Main] Improve error messages with vformat
#99095
Open
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
reviewed
Nov 12, 2024
| @@ -315,13 +315,13 @@ void Performance::set_navigation_process_time(double p_pt) { | |||
| } | |||
|
|
|||
| void Performance::add_custom_monitor(const StringName &p_id, const Callable &p_callable, const Vector<Variant> &p_args) { | |||
| ERR_FAIL_COND_MSG(has_custom_monitor(p_id), "Custom monitor with id '" + String(p_id) + "' already exists."); | |||
| ERR_FAIL_COND_MSG(has_custom_monitor(p_id), vformat("Custom monitor with id '%s' already exists.", String(p_id))); | |||
There was a problem hiding this comment.
Explicitly casting to String is not needed for vformat() I think.
There was a problem hiding this comment.
I think so too, as with the other batch I kept all the other details as they were, this batch is relatively small so will change them here and check, wanted to avoid any potential regression from this as some potential errors might not show up unless the error is actually triggered
AThousandShips
force-pushed
the
improve_err_prints_main
branch
from
d57bb4e to
f2f2d42
Compare
AThousandShips
force-pushed
the
improve_err_prints_main
branch
from
f2f2d42 to
3edd96a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
vformat#98091