Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bottom panel switch when pinned and removed #99096

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Nov 11, 2024

When a bottom panel is opened, pinned, then removed, it doesn't properly change the bottom panel:

This can be seen by moving the Filesystem dock to the bottom panel, pinning it, then moving it out of the bottom panel, or when disabling a custom bottom panel plugin.

Screenshot 2024-11-11 171115

Also the Filesystem Editor Docks menu option and the Show in Filesystem action should still switch when the filesystem is at the bottom.

@kitbdev kitbdev requested review from a team as code owners November 11, 2024 23:25
@Calinou Calinou added this to the 4.4 milestone Nov 12, 2024
@badsectoracula
Copy link
Contributor

I did a quick test and this works as expected (i was a bit surprised initially because i first tried the behavior without the PR here and when i switched the filesystem dock to the bottom left side again the bottom panel was closed while i expected it to remain open but empty as in the screenshot, so i thought the bug was fixed already but then i tried after also applying the PR and saw the difference in behavior - something to keep in mind by anyone who decides to review this later!).

@Repiteo Repiteo merged commit b98eeb3 into godotengine:master Dec 30, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 30, 2024

Thanks!

@kitbdev kitbdev deleted the bottom_panel_force_switch branch December 30, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants