Improve GDScript autocompletion for methods

[Lazy-Rabbit-2001]

Implements the part 1 of godotengine/godot-proposals#11079
Check the link for details about the reason why this pr is posted.

[Lazy-Rabbit-2001]

Kinda off-topic, but it surprised me that the back braces will not get overlapped. In previous versions, trying completing your code inside a couple of round brackets will remove the back brace if the completion is about a method or a keyword with (), like this:

print(is_inside_tree() # <- Here the back brace of `is_inside_tree()` is missing, or overlapping with the outer one.

I'm not sure if it is this pr or some other pr in this version that fixed this bug, or maybe it's because I haven't tested edge situation yet. But it seems to be a good sign.

[Calinou]

Kinda off-topic, but it surprised me that the back braces will not get overlapped.

It depends on whether you accept the suggestion with Tab or Enter. See #90723 which changes this behavior to be more predictable.

[Calinou]

Tested locally, it works as expected. Code looks good to me.

This is a nice usability improvement 🙂

[AdriaandeJongh]

Considering the autocomplete popup uses a monospaced font, and the three dots inside function parentheses take up a considerable width, may I suggest using this character instead?

…

[HolonProduction]

This is indeed a nice improvement. I think the usage of … works better:

Looks good to me on code and functionality side. You still need to squash the commits before this can get merged.

[HolonProduction]

Ok, now it's squashed, but could we get a meaningful commit name? E.g. just the title of the PR. If you already squashed you can use amend for it:

git commit --amend -m "Improve GDScript autocompletion for methods"
git push -f

[Repiteo]

Thanks! Congratulations on your first merged contribution! 🎉

[Meorge]

I'm sorry to be a bit of a downer on this, but at least would there be a way to change this behavior depending on whether or not Godot's internal editor is receiving the suggestions versus an external IDE? The new behavior is inconsistent with other languages in VS Code, where the parentheses are never given after brackets in the suggestion list or the actual completed code.

Currently, for GDScript, starting to type out print:

Immediately after hitting Enter/Return:

By contrast, here are some other popular languages in VS Code:

For Python, starting to type out print:

Immediately after hitting Enter/Return:

For TypeScript, starting to type out console.log:

Immediately after hitting Enter/Return:

For C/C++, starting to type out print_line:

Immediately after hitting Enter/Return:

It seems the standard is to not include parentheses in the suggestions for function/method names, and to not insert them once the user accepts the suggestion. Perhaps it makes more sense for Godot's built-in editor, but for external ones such as VS Code it looks to be different. IMO it'd make sense to either change the autocomplete behavior depending on the recipient (built-in editor vs external editor), or change the built-in editor's behavior so that it is more consistent with other language servers.

[HolonProduction]

I think only referencing language servers developed by Microsoft might be a bit biased (I suppose you are using the Microsoft c++ language server).

Here are some counter examples:

clangd C++ language server:

Dart integration

Java (the oracle plugin)

[Meorge]

Thanks for providing the counterexamples! You're right that they were all Microsoft-developed servers, as far as I know - my thought was that since Microsoft originally developed the specification, if there was a standard for how/when to do things like insert parentheses, the Microsoft servers would be the most likely to follow it to a T.

The documentation for VS Code's Rust support on their website features rust-analyzer, which also shows (...) after function/method names 🙂

Given that these other big language servers do it as well, I agree having the GDScript server do it is all good. 😄