Windows: Avoid child processes inheriting all file handles #99107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
force-pushed
the
win_less_inheritance
branch
3 times, most recently
from
cf4e2ba to
6d7ca5b
Compare
bruvzg
approved these changes
Nov 12, 2024
RandomShaper
force-pushed
the
win_less_inheritance
branch
from
6d7ca5b to
bbb040a
Compare
RandomShaper
force-pushed
the
win_less_inheritance
branch
from
bbb040a to
7fcf3c4
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, child processes would inherit all the open handles. Handle inheritance is needed so both parent and child can communicate via pipes. However, full inheritance could lead to hard to diagnose file-in-use (sharing violation) issues in cases either the editor or the running project has to run external commands.
This PR adds use of the extended API to condition the spawning of a child process, that gives fine-grained control on the set of inheritable handles. Now only the pipes are inherited.
Version for 4.3 submitted as #99108.