Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when selecting a keyframe in AnimationPlayer #99173

Closed
wants to merge 1 commit into from
Closed

Fix crash when selecting a keyframe in AnimationPlayer #99173

wants to merge 1 commit into from

Conversation

timoschwarzer
Copy link
Contributor

This is a regression of #97415.

Crash reproduction:

  1. Add an AnimationPlayer
  2. Create a new track (type does not matter)
  3. Create a keyframe in that track
  4. Select the keyframe

@timoschwarzer timoschwarzer requested a review from a team as a code owner November 13, 2024 14:24
@AThousandShips
Copy link
Member

Thank you for your contribution, however there's already an open PR doing this exact fix open:

Closing as a duplicate, thank you nonetheless

@timoschwarzer
Copy link
Contributor Author

@AThousandShips Damn, I searched for "AnimationPlayer crash" but "AnimationPlayer" is not mentioned in that PR 😆 Thanks!

@AThousandShips
Copy link
Member

In the future you can use prs-by-file to check what other PRs modify files you are interested in, it can help with these sorts of duplicates!

@timoschwarzer
Copy link
Contributor Author

Today I learned. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timoschwarzer @AThousandShips