Improve editor file dialog options #99182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
regression
topic:editor
usability
topic:gui
cherrypick:4.3
timoschwarzer
force-pushed
the
fix/editor-save-dialog-options
branch
from
e228549 to
8de06e5
Compare
timoschwarzer
force-pushed
the
fix/editor-save-dialog-options
branch
from
8de06e5 to
575c680
Compare
|
If not retaining the order of options is a deal breaker, let me know. I can change the PR to group only consecutive Checkboxes and OptionButtons together. |
KoBeWi
reviewed
Dec 9, 2024
KoBeWi
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
I checked all alternative PRs.
#97892 does not look good with mixed options.
#95304 is poorly aligned.
#95140 has conflicts, so I didn't test it.
Also here's native dialog (Windows) for reference:
I tested with various combinations and it looks like vertical GridContainer.
I think this PR is the best option.
Looks very clean.
timoschwarzer
force-pushed
the
fix/editor-save-dialog-options
branch
from
575c680 to
11bf2da
Compare
|
Applied suggestions and rebased. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95079.
While fixing the check boxes not being clickable, it improves the layout to be more space efficient and clean.
Alternatives
HFlowContainerto display file dialog options #97892This PR looks the same as that one for dialogs with Checkboxes only. That PR has the issue that labels for OptionButtons would be directly next to the labels of a previous Checkbox. This PR puts the OptionButtons separately to mitigate that issue.
That PR uses CheckButtons which do not fit semantically. Also does not show options next to each other, wasting space.
Does not handle OptionButton options well.
Screenshots
Current:
New:
New with Checkboxes and OptionButtons:
One notable change is that the checkboxes will always be displayed above the OptionButtons, which I think is fine here. I could not come up with a case where it's strictly necessary to retain the order between the options.