Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation for TileSetAtlasSource texture_region_size #99204

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

berarma
Copy link
Contributor

@berarma berarma commented Nov 13, 2024

No description provided.

@berarma berarma requested a review from a team as a code owner November 13, 2024 21:59
@Chaosus Chaosus added this to the 4.4 milestone Nov 14, 2024
@Mickeon Mickeon requested a review from groud November 14, 2024 21:43
@Mickeon
Copy link
Contributor

Mickeon commented Nov 14, 2024

I glanced at the code. Frankly, I'm not even sure what that statement in the class reference is useful for, and the explanation in the PR... well, there's none. Would you like to elaborate?

@berarma
Copy link
Contributor Author

berarma commented Nov 14, 2024

The tile set editor uses the tile size of the TileSet by default, thus I guess they can be equal and it makes sense to me. It can also be set to a smaller value but it would be unusual to have smaller tiles than the tile grid size and I don't know if it could cause problems. That's the reason for this proposal. Someone else will know better than me.

@groud
Copy link
Member

groud commented Nov 15, 2024

I glanced at the code. Frankly, I'm not even sure what that statement in the class reference is useful for, and the explanation in the PR... well, there's none. Would you like to elaborate?

Well, the default value for texture_region_size is equal to the tile_size (and can be increased), so the change is technically right.

@berarma
Copy link
Contributor Author

berarma commented Nov 15, 2024

I was only aiming for correctness but if anyone thinks the text could be improved in some other way I could try to give it a go.

@akien-mga akien-mga changed the title "Base tile size equal or bigger than" in TileSetAtlasSource Clarify documentation for TileSetAtlasSource texture_region_size Nov 29, 2024

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
@akien-mga
Copy link
Member

Rebased and squashed the commits, this is now ready to merge.

@akien-mga akien-mga merged commit 778723d into godotengine:master Nov 29, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants