Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary array construction when initializing the project manager #99213

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

timothyqiu
Copy link
Member

The Vector is constructed by adding a couple of strings. The vector is then iterated over directly in order to access those strings. So this vector is redundant.

Also removed unnecessary header includes from that cpp file.

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May have been copypasted from somewhere else where this was actually necessary.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Nov 14, 2024
@Repiteo Repiteo merged commit 9b3063b into godotengine:master Nov 14, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 14, 2024

Thanks!

@timothyqiu timothyqiu deleted the direct branch November 14, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants