-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update miniupnpc include paths #99218
Conversation
Looks like it doesn't build for other platforms, will take a look |
The problem here is that unlike most C/C++ libraries, miniupnpc has a discrepancy between the includes it uses for building from source, and the includes it expects from other applications using its public headers. The files in So Godot's own code that uses this builtin copy of miniupnpc also has But the miniupnpc pkgconfig file forces a use relative to We could move IMO we should just partially revert that change, as miniupnpc's pkgconfig file is IMO incorrect. |
CC @dustdfg |
Thank you for the very detailed explanation! That all sounds incredibly annoying and a splitting headache. We should update the issue with this explanation. |
Fixes some include since we removed adding the miniupnpc lib to the path.
Fixes #99196