Fix missing native file dialog title translation. #99223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 14, 2024
scene/gui/file_dialog.cpp
Outdated
| @@ -67,10 +67,11 @@ void FileDialog::_native_popup() { | |||
| } else if (access == ACCESS_USERDATA) { | |||
| root = OS::get_singleton()->get_user_data_dir(); | |||
| } | |||
| String tr_title = atr(get_title()); | |||
There was a problem hiding this comment.
Apparently this shadows tr_title from Window.
Two things then:
- This could likely use
tr_titledirectly? - But to do it properly it would likely make sense to make
tr_titleprivate and add a getter likeget_translated_title.
Or just make tr_title private and recompute it here. If it's not something we need often, it probably shouldn't spill out of Window internal usage.
There was a problem hiding this comment.
If we do decide to add a getter, then this can be simplified too:
main/viewport.cpp
333: TextLine title_text = TextLine(p_window->atr(p_window->get_title()), title_font, font_size);
There was a problem hiding this comment.
Added get_translated_title.
bruvzg
force-pushed
the
fd_title_transl
branch
2 times, most recently
from
75519d4 to
6f89ada
Compare
bruvzg
force-pushed
the
fd_title_transl
branch
from
6f89ada to
932b226
Compare
akien-mga
approved these changes
Nov 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99207