Resource UID fixes and improvements #99226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Nov 14, 2024
|
copy/paste from what I wrote on RC: I think UIDs should only be for resource loading, not the file access plus doc should be changed in FileAccess and DirAccess that the resource layer should be used instead unless specifically needed |
reduz
reviewed
Nov 14, 2024
| #ifdef DEBUG_ENABLED | ||
| if (p_path.begins_with("res://") && ResourceLoader::exists(p_path)) { |
There was a problem hiding this comment.
This function is kind of tricky, but I think if you supply an UID it should just not work.
There was a problem hiding this comment.
See the linked issue.
The expectation is different apparently.
|
Removed the FileAccess change. |
|
Thanks! |
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uid_to_path(uid)- convertsuid://tores://path_to_uid(path)- opposite of the aboveensure_path(uid_or_path)- returns a path, converts UID when necessaryIn a follow-up I plan to make use of the helper methods where applicable.