Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort blend shapes in the inspector by ID instead of alphabetically #99231

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

fire
Copy link
Member

@fire fire commented Nov 14, 2024

Fixes: godotengine/godot-proposals#11155

Blend shapes (morph targets, shape keys) should be sorted by the physical order of the blend shapes, and the index should be converted to a name string.

Before (Godot 4.3)

The blend shape indices are scrambled.

editor_screenshot_2024-11-14T055031

After (this pr)

Notice the artist has used spacers.

editor_screenshot_2024-11-14T054908

@fire fire force-pushed the sort-blendshapes-by-id branch from 7de550e to 78c8ddd Compare November 14, 2024 13:32
@fire fire marked this pull request as ready for review November 14, 2024 13:46
@fire fire requested a review from a team as a code owner November 14, 2024 13:46
@fire fire requested review from a team and TokageItLab November 14, 2024 13:46
@fire fire force-pushed the sort-blendshapes-by-id branch from 78c8ddd to 1ef78fd Compare November 14, 2024 13:53
@fire fire changed the title Show blend shape IDs and sort by ID instead of alphabetically Sort blend shapes in the inspector by ID instead of alphabetically Nov 14, 2024
Blend shapes (morph targets, shape keys) should be sorted by the physical order of the blend shapes, and that index should be converted to a name string.
@fire fire force-pushed the sort-blendshapes-by-id branch from 1ef78fd to b0e04c1 Compare November 14, 2024 13:54
@JekSun97
Copy link
Contributor

This definitely makes sense.

@Jesusemora
Copy link
Contributor

Jesusemora commented Nov 14, 2024

@Jesusemora

Can you test with your samples and write if it works for you in the godotengine/godot#99231 pull request?

I was about to make the changes myself, you beat me to it, this was so fast.

I have compiled the code and tested it and it seems to work.
shapekeys appear in order by ID and alter the mesh appearance:
Captura desde 2024-11-14 14-01-05

then I ran a script using the set method and it also works.

the only thing left would be to see the ID number somehow, but maybe we need some kind of slider with a number for that.

@TokageItLab TokageItLab modified the milestones: 4.x, 4.4 Nov 14, 2024
@Repiteo Repiteo merged commit 1680edb into godotengine:master Nov 19, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 19, 2024

Thanks!

@fire fire deleted the sort-blendshapes-by-id branch November 19, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Show blend shape IDs and sort by ID instead of alphabetically
7 participants