Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input] [Windows] Limit for-loop to the 14 actually available buttons for XInput #99313

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MJacred
Copy link
Contributor

@MJacred MJacred commented Nov 16, 2024

See https://learn.microsoft.com/en-us/windows/win32/api/xinput/ns-xinput-xinput_gamepad#members.

Note: marking as draft, as I'd like to test on Windows first. Just in case.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Windows 11 24H2 (rebased on top of master 71d80b2), this breaks the X/Y buttons on a wired Xbox Elite Series 2 controller which aren't recognized anymore. Other buttons work correctly.

@MJacred
Copy link
Contributor Author

MJacred commented Jan 28, 2025

Thanks for testing! Not sure why this happens… Looking at the buttons in that list, they mostly overlap with Godot's JoyButtons, except for JOY_BUTTON_GUIDE, which xinput doesn't provide. While that could explain X or Y not working. But both of them puzzles me right now.
I have a few busy weeks ahead, afterwards, I'll look into this again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants