Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix key is deselected by changing key time in KeyEdit in FPS mode #99319

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix key is deselected by changing key time in KeyEdit in FPS mode #99319

merged 1 commit into from
Nov 20, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Nov 16, 2024 •
edited
Loading

KeyEdit in FPS mode is unstable (like #99320), but this fix does not particularly help that fix, and we are partially revert because of the problem.

@TokageItLab TokageItLab requested a review from a team November 16, 2024 14:50
@TokageItLab TokageItLab requested a review from a team as a code owner November 16, 2024 14:50
@TokageItLab TokageItLab added this to the 4.4 milestone Nov 16, 2024
SaracenOne
SaracenOne approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was discussed and demonstrated in the Animation meeting and seems fine 👍

@fire fire changed the title Fix key is deselected by chaning key time in KeyEdit in FPS mode Fix key is deselected by changing key time in KeyEdit in FPS mode Nov 17, 2024
@akien-mga akien-mga merged commit b11bb1a into godotengine:master Nov 20, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

@Repiteo Repiteo Repiteo approved these changes

Assignees
No one assigned
Labels
bug regression topic:animation topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@TokageItLab @akien-mga @SaracenOne @Repiteo