Add Toggle selection mode to ItemList
#99355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havi05
force-pushed
the
itemlist-toggle-mode
branch
from
753f283 to
ce88fc5
Compare
havi05
force-pushed
the
itemlist-toggle-mode
branch
from
ce88fc5 to
5e3455c
Compare
|
I think the |
KoBeWi
reviewed
Dec 12, 2024
KoBeWi
reviewed
Dec 12, 2024
KoBeWi
reviewed
Dec 12, 2024
KoBeWi
approved these changes
Dec 12, 2024
havi05
force-pushed
the
itemlist-toggle-mode
branch
from
5e3455c to
b29e93b
Compare
|
Applied the requested changes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a
Toggleselection to theItemListnode. Now you can select an item and deselect it by clicking on it again.Closes godotengine/godot-proposals#6371
It emits the signal
multi_selectedwhen a value changes. I think it would be clearer if it would be renamed toselection_changed, for example, but that would be a breaking change. Of course it would be possible to add a new signal, but that would duplicate the functionality.What do you think?
Should I just change the description of
multi_selectedto add the toggle mode?