Fix issues with animation markers drawing #99363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passivestar
force-pushed
the
fix-marker-drawing
branch
from
a895565 to
25d68c2
Compare
fire
approved these changes
Nov 17, 2024
TokageItLab
approved these changes
Nov 17, 2024
SaracenOne
approved these changes
Nov 17, 2024
passivestar
force-pushed
the
fix-marker-drawing
branch
from
25d68c2 to
c4a78d0
Compare
|
When testing with different scale I noticed that marker font size was missing an |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animation markers introduced in #91765 draw unnecessary separator lines in the header over the already existing lines. This seems to be an oversight because those lines don't seem to have anything to do with markers and double lines are hard to spot in the default theme. However in my theme they introduced a noticeable regression because I'm not using those separators and #91765 drew some unthemable ones.
I also added missing
EDSCALEwhen drawing marker lines for better HiDPI support and added a little space around the marker label textBefore/After fixes in this PR:
You can notice the line being drawn twice in the default theme in close comparison: