GDExtension: Fix method binds not saying if they are varargs #99403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
bug
topic:gdextension
cherrypick:4.3
Ivorforce
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
I just tested this branch. Can confirm it fixes godotengine/godot-cpp#1641. Thanks!
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes godotengine/godot-cpp#1641
For whatever reason,
GDExtensionMethodBind::is_vararg()was hard-coded to returnfalse- possibly we didn't originally support varargs, added support later, and then didn't update that?Anyway, this PR updates it to return the correct value, which will prevent GDScript from trying to do a validated call for vararg functions (which isn't supported), fixing the bug.