SCons: Remove code for unsupported compilers

[dustdfg]

Follow up to: #99217 and #98842

[dustdfg]

There is also one place where VCINSTALLDIR is used. I don't know much about VS so have a question. It is defined for all VS versions or only for VS >= 2017 VS <= 2017?

https://github.com/godotengine/godot/blob/c264100da2d021b3d107f18f5adf74bdaeb60547/platform/windows/detect.py#L51-L52

[Repiteo]

Oop, should've specified, the fix I showed extended to the rest of the conditional; you'll have to remove lines 120-123 as well

[dustdfg]

Oop, should've specified, the fix I showed extended to the rest of the conditional; you'll have to remove lines 120-123 as well

Already was checking for correctness. Pressing "commit changes" and then checking out to pr's head is the easiest way to get the changes in local which I know... Btw thanks for clarifying! 🙂

[Repiteo]

It also seems that VCINSTALLDIR indeed is on later VS versions, or at least on my VS2022 version. I assume then that the later check is more thorough and/or VCTOOLSINSTALLDIR wasn't introduced until VS2017.

[dustdfg]

It also seems that VCINSTALLDIR indeed is on later VS versions, or at least on my VS2022 version. I assume then that the later check is more thorough and/or VCTOOLSINSTALLDIR wasn't introduced until VS2017.

Looks like I understood words but honestly I couldn't parse it. Looks like I've already got debuff on mind capabilities 😅 Could you rephrase please?

[Repiteo]

Short version: it could still be used. So while legacy, it's not necessarily unsupported, and should probably be kept as-is for now. Maybe this PR could be refactored to just have the SConstruct change

[dustdfg]

It is not so much sense to merge deletion of two lines of stale code which won't create any problems. I will glue it with some other misc edits