Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Improve TextureProgress.set_radial_initial_angle() by removing loops #99434

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

arkology
Copy link
Contributor

@arkology arkology commented Nov 19, 2024

Backport #98816 to 3.x
Fixes #60338

Some notes:

  • There are not Math::is_finite() and Math::fposmodp() in 3.x, so Math::is_finite() replaced with isfinite() from math.h stdlib (just expanding function Math::is_finite() from 4.x branch - feel free to suggest how it could be done differently), and Math::fposmodp() replaced with Math::fposmod() (same as Math::fposmodp() but with more checks).
  • No unit tests added (as they are 4.x privilege), but in editor it works as expected.

@arkology arkology requested review from a team as code owners November 19, 2024 18:23
@Chaosus Chaosus added this to the 3.x milestone Nov 20, 2024
@arkology
Copy link
Contributor Author

cc @AThousandShips please take a look when you have time.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants