Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SVG font rendering. #99459

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix SVG font rendering. #99459

merged 1 commit into from
Nov 27, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 20, 2024

  • Fixes SVG font rendering broken by latest ThorVG update.
  • Removes usage of private ThorVG API.

@bruvzg bruvzg added this to the 4.4 milestone Nov 20, 2024
@fire
Copy link
Member

fire commented Nov 20, 2024

Let us know when it's ready to be tested.

@bruvzg bruvzg marked this pull request as ready for review November 20, 2024 15:47
@bruvzg bruvzg requested a review from a team as a code owner November 20, 2024 15:47
fire
fire approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this works, but fewer private apis are good, and avoiding regressions is also good.

@fire
Copy link
Member

fire commented Nov 21, 2024

What was broken? is there a mrp?

AThousandShips
AThousandShips reviewed Nov 21, 2024
View reviewed changes
@bruvzg
Copy link
Member Author

bruvzg commented Nov 21, 2024

What was broken?

Everything, it was failing to load any SVG font since private API we were using start returning zero size bounding box after some of the updates.

Repiteo
Repiteo approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codestyle checks out

@Repiteo Repiteo merged commit 4e079ee into godotengine:master Nov 27, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips

@fire fire

@Repiteo Repiteo

Assignees
No one assigned
Labels
bug regression topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@bruvzg @fire @Repiteo @AThousandShips