Improve appearance of external links in built-in docs #99480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the bikeshed should be normal link colored. |
dalexeev
reviewed
Nov 20, 2024
Mickeon
force-pushed
the
doc-help-external-link-icon
branch
from
922cc37 to
1285f93
Compare
|
Updated the PR to also reduce code duplication. |
dalexeev
reviewed
Nov 20, 2024
Mickeon
force-pushed
the
doc-help-external-link-icon
branch
from
1285f93 to
6c675d4
Compare
dalexeev
approved these changes
Nov 21, 2024
akien-mga
approved these changes
Nov 28, 2024
|
Why the dotted underline for the links? (not related with this PR) |
|
It's because of the |
|
Ah right, then let's wait for #99481 to be merged first. |
Mickeon
force-pushed
the
doc-help-external-link-icon
branch
from
6c675d4 to
b22bb4d
Compare
|
Rebased to use #99481 instead. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#9369
This PR makes the external links in the built-in class reference:
I'm unconvinced on the actual color, though. See also a RocketChat thread. The gist of it is that, I feel like the excessive accent colour brings too much attention to external links, and the icon exists too. Links to the built-in class reference are more important in the editor and should be more notable, as well.
It's also currently not possible to hide the
hinttag's underline individually. Hence the dotted underline on these links.