[.NET] Preserve no-hint behavior for unmarshallable generics in dictionaries #99485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
raulsntos
commented
Nov 21, 2024
raulsntos
commented
- Fixes C#: Script Generator fails when using generics in a dictionary. #99454
raulsntos
force-pushed
the
dotnet/dictionary-compat
branch
from
952ec45 to
e9bc573
Compare
paulloz
reviewed
Nov 21, 2024
| return false; | ||
| } | ||
|
|
||
| var keyElementVariantType = MarshalUtils.ConvertMarshalTypeToVariantType(keyElementMarshalType!.Value)!.Value; |
There was a problem hiding this comment.
We shouldn't need the null-suppression operator on keyElementMarshalType here, since it's already checked by the condition above. Same thing for valueElementMarshalType below.
There was a problem hiding this comment.
Oh, you are right. I just copy-pasted without thinking.
raulsntos
force-pushed
the
dotnet/dictionary-compat
branch
from
e9bc573 to
4e5080d
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.