Make loading translations from threads safe #99527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
added
bug
topic:core
cherrypick:4.3
Norrox
approved these changes
Nov 22, 2024
akien-mga
approved these changes
Nov 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98577.
Note that when loading a translation from a thread, by the time the load is reported to be complete, the
NOTIFICATION_TRANSLATION_CHANGEDmay have not been delivered yet. That will happen the next time the message queue is flushed, so no later than one frame. However, if that's an issue, I can add some extra logic so resource classes have a way to communicate theResourceLoaderit shouldn't call the load complete until some condition has been met. That's what happens with the resource changed mechanism, for instance.