Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert line breaks to \n and strip line break from the end of string returned by OS::read_string_from_stdin/OS::get_stdin_string. #99542

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Convert line breaks to \n and strip line break from the end of string returned by OS::read_string_from_stdin/OS::get_stdin_string. #99542

merged 1 commit into from
Nov 25, 2024
+3 −2

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 22, 2024

  • Replaces \r\n with \n (can be in the middle of the string is pipe/redirection is used).
  • Strips line breaks from the end of the string.

Fixes #80136

@bruvzg bruvzg added this to the 4.4 milestone Nov 22, 2024
@bruvzg bruvzg marked this pull request as ready for review November 23, 2024 12:35
@bruvzg bruvzg requested review from a team as code owners November 23, 2024 12:35
Mickeon
Mickeon reviewed Nov 23, 2024
View reviewed changes
@bruvzg
Convert line breaks to \n and strip line break from the end of stri…
e9b57fc 
…ng returned by `OS::read_string_from_stdin`/`OS::get_stdin_string`.
@Mickeon
Copy link
Contributor

Mickeon commented Nov 23, 2024

Does it also mean that the original reported issue should be considered a bug?

@Repiteo Repiteo requested a review from a team November 23, 2024 15:59
akien-mga
akien-mga approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga mentioned this pull request Nov 25, 2024
Closed
@Repiteo Repiteo merged commit 0d88737 into godotengine:master Nov 25, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Repiteo Repiteo Repiteo approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

A string from the standard input is incorrectly compared with another
4 participants
@bruvzg @Mickeon @Repiteo @akien-mga