Change navigation map performance monitor to use a struct #99626
Conversation
Changes navigation map performance monitor to use a struct as it is easier to pass to sub functions.
| @@ -298,6 +298,19 @@ class Heap { | |||
| } | |||
| } | |||
| }; | |||
|
|
|||
| struct PerformanceData { | |||
| int pm_region_count = 0; | |||
There was a problem hiding this comment.
If the struct is called "performance_data" why are all members still prefixed with pm, which I assume means "performance"?
There was a problem hiding this comment.
I had the prefix originally removed but reverted and added it back in. Without that prefix it turns the code readability into a shitshow when you dont have a more sophisticated IDE as your mental crutch available. There are so many similar temp variables all over the place in sub functions that can be easily confused and the pm_ prefix makes it very clear what is what.
There was a problem hiding this comment.
I agree with @Mickeon - as the fields are always prefixed with [name]. it's possible to have good readability without that pm_ prefix
|
Thanks! |
Changes navigation map performance monitor to use a struct as it is easier to pass to sub functions.
It is impossible to split that giant map sync function with so many properties that would need to be passed to sub functions individually.