Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment unit tests for OptionButton #99632

Merged

Conversation

wheatear-dev
Copy link
Contributor

Further to this comment on my previous PR #93824, this new PR implements the (optional) improvements that were suggested by @Geometror .

A new SUBCASE has been provided, that verifies the getters and setters for:

  1. item_text
  2. item_tooltop
  3. item_metadata

Hope it was worth the wait! 😅

@wheatear-dev wheatear-dev requested a review from a team as a code owner November 24, 2024 16:08
@wheatear-dev wheatear-dev changed the title Add getter and setter unit tests for OptionButton Augment getter and setter unit tests for OptionButton Nov 24, 2024
@wheatear-dev wheatear-dev force-pushed the augment-tests-option-button branch 2 times, most recently from 54ebffa to 61e22c1 Compare November 24, 2024 16:19
@wheatear-dev wheatear-dev changed the title Augment getter and setter unit tests for OptionButton Augment unit tests for OptionButton Nov 24, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@akien-mga akien-mga modified the milestones: 4.4, 4.5 Feb 24, 2025
@Repiteo Repiteo merged commit 75f131e into godotengine:master Mar 11, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Mar 11, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants