Fix default Environment project setting and loading
#99739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Nov 27, 2024
KoBeWi
reviewed
Nov 27, 2024
ydeltastar
force-pushed
the
fix-default-environment
branch
6 times, most recently
from
771d076 to
489e699
Compare
ydeltastar
force-pushed
the
fix-default-environment
branch
from
489e699 to
8793764
Compare
KoBeWi
approved these changes
Nov 28, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environmentin project settings resets after project reloads and give errors #99732When a project opens, the scene tree tries to load the default
Environmentwhile the editor is still scanning the filesystem. This causes issues and errors since theuid://may not have been mapped yet.This PR ensures it only tries to load when it is mapped.