Use Vector4 for texture mask in BaseMaterial to avoid converting to and from Plane #99743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Nov 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #84633
Fixes: #99663
Supersedes: #84650
It seems like ShaderMaterial doesn't serialize Plane properly (or it doesn't handle converting back and forth between Plane and Vector4 gracefully). #84650 fixes the issue by forcing the plane to become a Vector4 during conversion, but the solution can be even cleaner by just never using a Plane.
The fact that this change fixes the issue hints at a deeper issue with how we serialize shader params as both Plane and Vector should work fine. But we should go ahead with this small fix for now and investigate deeper later if necessary.