Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebSocket] Clarify that connect_to_url is non-blocking #99753

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[WebSocket] Clarify that connect_to_url is non-blocking #99753

merged 1 commit into from
Dec 2, 2024

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Nov 27, 2024

Fixes #81839

@Faless Faless added this to the 4.4 milestone Nov 27, 2024
@Faless Faless requested review from a team as code owners November 27, 2024 12:31
@akien-mga akien-mga changed the title [WebSocket] Clarify that connect_to_url is non-blocking [WebSocket] Clarify that connect_to_url is non-blocking Dec 2, 2024
@akien-mga akien-mga merged commit 9f36f3b into godotengine:master Dec 2, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

WebSocketPeer.connect_to_url() always returns 0 i.e, OK
3 participants
@Faless @akien-mga @AThousandShips